Skip to content

regression: showing the unsupported error#35338

Closed
Gustrb wants to merge 2 commits intodevelopfrom
regression/not-showing-unsupported-version-screen
Closed

regression: showing the unsupported error#35338
Gustrb wants to merge 2 commits intodevelopfrom
regression/not-showing-unsupported-version-screen

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 26, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Introduced from: #35059

I believe we should think about having a better way of identifying errors from the marketplace instead of just matching the string...

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: edc3bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb changed the title chore: showing the unsupported error regression: showing the unsupported error Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (a2460ef) to head (edc3bf6).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35338   +/-   ##
========================================
  Coverage    59.42%   59.42%           
========================================
  Files         2829     2829           
  Lines        68336    68336           
  Branches     15133    15133           
========================================
  Hits         40612    40612           
  Misses       25066    25066           
  Partials      2658     2658
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb closed this Feb 27, 2025
@tassoevan tassoevan deleted the regression/not-showing-unsupported-version-screen branch July 30, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Gustrb